Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the signing key optinal jf release-bundle-create #2762

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Make the signing key optinal jf release-bundle-create #2762

merged 5 commits into from
Nov 21, 2024

Conversation

oshratZairi
Copy link
Collaborator

@oshratZairi oshratZairi commented Nov 17, 2024 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Turn the signing key flag to optional for RBC and in RBP command.
Documentation PR jfrog/documentation#172

@lesnerd lesnerd added the improvement Automatically generated release notes label Nov 17, 2024
@lesnerd lesnerd requested review from lesnerd, RobiNino and eyalbe4 and removed request for lesnerd November 17, 2024 14:52
@lesnerd lesnerd added the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@lesnerd lesnerd added the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@lesnerd lesnerd added the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
eyalbe4
eyalbe4 requested changes Nov 20, 2024
View reviewed changes
lifecycle_test.go Show resolved Hide resolved
lifecycle_test.go Outdated Show resolved Hide resolved
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 changed the title Optinal signing key for RBC Make the signing key optinal jf release-bundle-create Nov 20, 2024
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@lesnerd lesnerd added the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2024
@eyalbe4 eyalbe4 merged commit 6fa5830 into jfrog:dev Nov 21, 2024
104 of 112 checks passed
oshratZairi added a commit to oshratZairi/jfrog-cli that referenced this pull request Nov 27, 2024
@oshratZairi
Make the signing key optinal jf release-bundle-create (jfrog#2762)
bb3329f
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@RobiNino RobiNino Awaiting requested review from RobiNino

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshratZairi @eyalbe4 @lesnerd