Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the signing key to be optional in RBC #2759

Closed
wants to merge 6 commits into from
Closed

Turn the signing key to be optional in RBC #2759

wants to merge 6 commits into from

Conversation

oshratZairi
Copy link
Collaborator

@oshratZairi oshratZairi commented Nov 14, 2024 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Turn the signing key to be optional in RBC

@lesnerd lesnerd added the improvement Automatically generated release notes label Nov 17, 2024
@lesnerd lesnerd self-assigned this Nov 17, 2024
@lesnerd lesnerd self-requested a review November 17, 2024 09:55
@lesnerd lesnerd added breaking change Automatically generated release notes and removed breaking change Automatically generated release notes labels Nov 17, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@lesnerd lesnerd added the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@lesnerd lesnerd closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesnerd lesnerd Awaiting requested review from lesnerd

Assignees

@lesnerd lesnerd

@oshratZairi oshratZairi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshratZairi @lesnerd @yahavi