Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install CLI with sudo #2240

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix install CLI with sudo #2240

merged 1 commit into from
Oct 4, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 4, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Fix #2239

@yahavi yahavi requested review from eyalbe4 and sverdlov93 October 4, 2023 16:14
@yahavi yahavi added bug Something isn't working safe to test Approve running integration tests on a pull request labels Oct 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 4, 2023
@yahavi yahavi linked an issue Oct 4, 2023 that may be closed by this pull request
CLI installer is broken by 2.49.0 release #2239
Closed
@yahavi yahavi self-assigned this Oct 4, 2023
@yahavi yahavi merged commit a8b6787 into jfrog:dev Oct 4, 2023
80 of 83 checks passed
@yahavi yahavi deleted the fix-install-cli branch October 4, 2023 16:25
@yahavi yahavi mentioned this pull request Oct 4, 2023
Closed
@ZhongRuoyu ZhongRuoyu mentioned this pull request Oct 5, 2023
Merged
@jokomo24
Copy link

Thanks for the fix but the script provided here: https://jfrog.com/blog/gitlab-and-artifactory-on-your-mark-get-set-build/ still installs the buggy version via curl -fL https://install-cli.jfrog.io | sh.

It wasn't until I installed 2.49.1 directly using curl -fL https://releases.jfrog.io/artifactory/jfrog-cli/v2-jf/2.49.1/scripts/install-cli.sh | sh that the issue was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@sverdlov93 sverdlov93 Awaiting requested review from sverdlov93

Assignees

@yahavi yahavi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI installer is broken by 2.49.0 release
3 participants
@yahavi @jokomo24 @eyalbe4