Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer plugin install - Trim the input JFrog home path #897

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Aug 17, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Trim the input JFrog home path in the jf rt transfer-plugin-install command.
This is important to make sure that the value does not contain any newlines or any other whitespaces.

@yahavi yahavi added the bug Something isn't working label Aug 17, 2023
@yahavi yahavi requested review from eyalbe4 and attiasas August 17, 2023 16:23
@yahavi yahavi self-assigned this Aug 17, 2023
@yahavi yahavi added improvement Automatically generated release notes and removed bug Something isn't working labels Aug 24, 2023
@yahavi yahavi merged commit a7f84a4 into jfrog:dev Aug 24, 2023
1 check failed
@yahavi yahavi deleted the install-plugin-trim branch August 24, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants