Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login command - Ensure JFrog Platform URL input is non-empty before proceeding #1308

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Login command - Ensure JFrog Platform URL input is non-empty before proceeding #1308

merged 7 commits into from
Dec 13, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Nov 28, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

avoid this situation:

Enter your JFrog Platform URL (Example: https://acme.jfrog.io):
[Error] providing JFrog Platform URL is mandatory

this shouldn't happen. this should wait untill the prompt contains a valid url

@sverdlov93
Improve upload archive progress bar
978fad9 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 changed the base branch from master to dev November 28, 2024 13:03
@sverdlov93 sverdlov93 requested review from yahavi and eyalbe4 November 28, 2024 13:03
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Nov 28, 2024
@sverdlov93
Improve upload archive progress bar
cf45057 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 requested review from eyalbe4 and RobiNino and removed request for eyalbe4 December 10, 2024 12:43
@sverdlov93 sverdlov93 merged commit 8e11807 into jfrog:dev Dec 13, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@RobiNino RobiNino Awaiting requested review from RobiNino

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @yahavi