Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utils enhancements to allow go support for JFrog Curation #1187

Merged
merged 11 commits into from
Jun 9, 2024
Merged

Utils enhancements to allow go support for JFrog Curation #1187

merged 11 commits into from
Jun 9, 2024

Conversation

asafambar
Copy link
Contributor

@asafambar asafambar commented May 23, 2024 •
edited by attiasas
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on: jfrog/build-info-go#255

@attiasas attiasas self-requested a review May 29, 2024 09:36
@attiasas attiasas added the improvement Automatically generated release notes label May 30, 2024
attiasas
attiasas reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add test cases for the new bool argument of getArtifactoryApiUrl

@attiasas attiasas mentioned this pull request May 30, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

eyalbe4
eyalbe4 requested changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my inline comments.
I'd love to run another review cycle following the implementation of my comments.

utils/golang/utils.go Outdated Show resolved Hide resolved
utils/golang/utils.go Outdated Show resolved Hide resolved
artifactory/commands/golang/go_test.go Outdated Show resolved Hide resolved
artifactory/commands/golang/go.go Outdated Show resolved Hide resolved
utils/golang/utils.go Show resolved Hide resolved
utils/golang/utils.go Outdated Show resolved Hide resolved
utils/golang/utils.go Show resolved Hide resolved
@eyalbe4 eyalbe4 changed the title curation go support Utils enhancements to support go support for JFrog Ccuration Jun 7, 2024
@eyalbe4 eyalbe4 changed the title Utils enhancements to support go support for JFrog Ccuration Utils enhancements to allow go support for JFrog Ccuration Jun 7, 2024
eyalbe4
eyalbe4 requested changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also create a PR for github.com/jfrog/jfrog-cli with an upgrade of the jfrog-cli-core and build-info-go modules that include the changes proposed in their PRs, and ensure the tests there are passing.
Let's link that jfrog-cli PR to this PR and the build-info-go PR.

@asafambar
Copy link
Contributor Author

Let's also create a PR for github.com/jfrog/jfrog-cli with an upgrade of the jfrog-cli-core and build-info-go modules that include the changes proposed in their PRs, and ensure the tests there are passing. Let's link that jfrog-cli PR to this PR and the build-info-go PR.

@attiasas will take care of that

@yahavi yahavi changed the title Utils enhancements to allow go support for JFrog Ccuration Utils enhancements to allow go support for JFrog Curation Jun 9, 2024
@eyalbe4 eyalbe4 merged commit f80a1af into jfrog:dev Jun 9, 2024
6 of 7 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas left review comments

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asafambar @eyalbe4 @attiasas