Artifactory Release Lifecycle Management - Add Import bundle function #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
RobiNino
requested changes
Mar 20, 2024
| } | ||
|
|
||
| func (rbi *ReleaseBundleImportCommand) Run() (err error) { | ||
| if err = validateArtifactoryVersionSupported(rbi.serverDetails); err != nil { |
There was a problem hiding this comment.
We can consider setting the supported version to the one that will include the fix, for this command only.
There was a problem hiding this comment.
i've added a function that will check if it is cloud platform, but what do you suggest about the version constraint? there is guarantee that it will be fixed the next patch.
There was a problem hiding this comment.
The problem with checking whether the instance is a cloud is that it requires admin privileges, which is not a constraint we would like to set.
To be on the safe side, I would suggest to keep the command hidden till the patch is officially out, then exposing it with the same minimal version for both cloud and self hosted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on:
jfrog/jfrog-client-go#921