Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifactory Release Lifecycle Management - Support release bundle creation by aql and artifacts #1142

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Artifactory Release Lifecycle Management - Support release bundle creation by aql and artifacts #1142

merged 7 commits into from
Mar 18, 2024

Conversation

RobiNino
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on jfrog/jfrog-client-go#915

@RobiNino RobiNino added the new feature Automatically generated release notes label Feb 29, 2024
@RobiNino RobiNino requested review from eyalbe4 and yahavi February 29, 2024 05:48
@RobiNino RobiNino mentioned this pull request Feb 29, 2024
Merged
4 tasks
yahavi
yahavi requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @RobiNino! Your coding is impressive!
However, this pull request lacks tests. Could you please add some table tests for the non-trivial functions?

artifactory/utils/search.go Outdated Show resolved Hide resolved
artifactory/utils/search.go Outdated Show resolved Hide resolved
lifecycle/createcommon.go Show resolved Hide resolved
lifecycle/createcommon.go Outdated Show resolved Hide resolved
lifecycle/createcommon.go Outdated Show resolved Hide resolved
lifecycle/createcommon.go Show resolved Hide resolved
lifecycle/createfromartifacts.go Show resolved Hide resolved
RobiNino added 2 commits March 18, 2024 09:04
@RobiNino
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into rb…
9b9d204 
…v2-aql-artifacts

# Conflicts:
#	go.mod
#	go.sum
#	lifecycle/createcommon.go
@RobiNino
cr comments
cf0dd84
@RobiNino RobiNino merged commit d806156 into jfrog:dev Mar 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @yahavi