Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer - Progress should only represent successful storage transfer #1000

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 17, 2023

This reverts commit 9b64c74.

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

image

Total files: 103
Delayed files: 34
Errors: 1

103 - 34 - 1 = 68.

  • Keep the phase 3 label fix

@yahavi yahavi added the bug Something isn't working label Oct 17, 2023
@yahavi yahavi requested a review from eyalbe4 October 17, 2023 13:29
@yahavi yahavi self-assigned this Oct 17, 2023
@yahavi yahavi changed the title Transfer - Progress should only represent the success storage transfer Transfer - Progress should only represent successful storage transfer Oct 17, 2023
utils/progressbar/progressbarmng.go Outdated Show resolved Hide resolved
@yahavi yahavi merged commit b1e98b9 into jfrog:dev Oct 18, 2023
7 of 8 checks passed
@yahavi yahavi deleted the revert-prog branch October 18, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants