Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent OOM when processing large gradle project with many depencies #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/com/jfrog/GradleDependencyTreeUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ private static void addUnresolvedConfiguration(GradleDependencyTree node, Config
private static void populateTree(GradleDependencyTree node, String configurationName, DependencyResult dependency, Set<String> addedChildren) {
GradleDependencyTree child = new GradleDependencyTree(configurationName);
if (dependency instanceof UnresolvedDependencyResult) {
if (!addedChildren.add(dependency.getRequested().getDisplayName())) {
return;
}
child.setUnresolved(true);
addChild(node, dependency.getRequested().getDisplayName(), child);
return;
Expand All @@ -91,7 +94,7 @@ private static void populateTree(GradleDependencyTree node, String configuration
}
addChild(node, moduleVersion.toString(), child);
for (DependencyResult dependencyResult : resolvedDependency.getSelected().getDependencies()) {
populateTree(child, configurationName, dependencyResult, new HashSet<>(addedChildren));
populateTree(child, configurationName, dependencyResult, addedChildren);
}
}

Expand Down