Enable conan support #781
Open
Enable conan support #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
reviewed
Nov 7, 2024
eranturgeman
reviewed
Nov 7, 2024
eranturgeman
reviewed
Nov 7, 2024
eranturgeman
reviewed
Nov 7, 2024
eranturgeman
reviewed
Nov 7, 2024
eranturgeman
reviewed
Nov 7, 2024
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
requested changes
Nov 10, 2024
orto17
force-pushed
the
enable-conan-support
branch
from
aeb1df3 to
48d1dbe
Compare
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
| return | ||
| } | ||
|
|
||
| func (conan *ConanPackageHandler) logNoInstallationMessage() { |
There was a problem hiding this comment.
This method is redundant and is being called only once, we can simple move this to the function where it is called.
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes support of conan requirements file update. It does not support installation of the suggested fixes. In order to update the dependencies, the user should run a 'conan install' command with the suggested conan file..