Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip comment generation on PR success if needed #778

Closed
wants to merge 9 commits into from

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Oct 30, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Add option to skip generating success comment (no issues), you can enable this option by:

  • using JF_PR_ADD_SUCCESS_COMMENT=false
  • adding addPrCommentOnSuccess: false to the config

@attiasas attiasas added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Oct 30, 2024
@attiasas attiasas requested a review from hadarshjfrog October 30, 2024 14:50
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 30, 2024
utils/comment.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment around what will be skipped and what won't.

Also - don't we have integration tests that checks the PR comments themselves?

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 30, 2024
@attiasas
Copy link
Contributor Author

added a comment around what will be skipped and what won't.

Also - don't we have integration tests that checks the PR comments themselves?

Nice comment, I added a check to show summary on issues or when requested comment (default)
We have integration tests that check the comments but the default behavior did not changed

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 30, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 3, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 1, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 1, 2024
@attiasas attiasas changed the title Add option to skip comment generation on PR success Skip comment generation on PR success if needed Dec 1, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 15, 2024
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants