-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan PR - Add option to scan source and most common ancestor target c… #763
Conversation
fix title + consider adding an explanation about when one should use this feature |
Where does useMostCommonAncestorAsTarget field be inserted in frogbot-config.yml? is it part of the 'Project' list or a general definition. In addition, please open a ticket to add this new field to ConfigProfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, see my comments
Scan PR/MR command
We are scanning both the source and target branches.
Then we compare the results and filter only those found in the source, not in the target.
The new option calculates the most common ancestor commit by running
git merge-base source target
, checking out to the commit, and treating it as the target to be merged to.To use this option you can:
JF_USE_MOST_COMMON_ANCESTOR_AS_TARGET
useMostCommonAncestorAsTarget
(atGit
section)