Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #12650 Fix multipart attribute for forwards. #12656

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Issue #12650 Fix multipart attribute for forwards. #12656

merged 2 commits into from
Dec 20, 2024

Conversation

janbartel
Copy link
Contributor

Fixes #12650

During a forward, the getAttributeNames method returns the attribute org.eclipse.jetty.multipartConfig if the servlet that is the origin of the forward supports multipart, whereas it should only return it if the servlet that is the target of the forward supports it.

@janbartel
Issue #12650 Fix multipart attribute for forwards.
c9ea390 
Only return the org.eclipse.jetty.multipartConfig attribute name on
getAttributeNames iff the servlet that is the target of the forward
supports multipart.
@janbartel janbartel added the Bug For general bugs on Jetty side label Dec 19, 2024
@janbartel janbartel requested a review from gregw December 19, 2024 07:43
@janbartel janbartel self-assigned this Dec 19, 2024
@janbartel janbartel mentioned this pull request Dec 19, 2024
Closed
gregw
gregw previously approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a checkstyle validation error.
Other than that, looks good... although we should probably consider using Attributes.Synthentic for this... but let's do that in 12.1.x

gregw
gregw approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note we can't use synthetic attributes because this is in the servlet API space.

@janbartel janbartel merged commit 818bd0e into jetty-12.0.x Dec 20, 2024
10 checks passed
@janbartel janbartel deleted the jetty-12.0.x-12650-multipart-attr branch December 20, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

Assignees

@janbartel janbartel

Labels
Bug For general bugs on Jetty side
Projects
Jetty 12.0.17
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attribute org.eclipse.jetty.multipartConfig is null
2 participants
@janbartel @gregw