Skip to content

Commit

Permalink
Issue #11413 - Conscrypt does not support server-side SNI.
Browse files Browse the repository at this point in the history
Addendum to #12549 to fix the silly mistake of returning null rather than the SNI host.

Thanks @brusdev for pointing that out.

Signed-off-by: Simone Bordet <[email protected]>
  • Loading branch information
sbordet committed Dec 12, 2024
1 parent 86a1c58 commit 4041e24
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ protected String retrieveSni(Request request, SSLSession session)
// Quick retrieval of the SNI from a SSLSession attribute put by SniX509ExtendedKeyManager.
String sniHost = (String)session.getValue(SslContextFactory.Server.SNI_HOST);
if (sniHost != null)
return null;
return sniHost;

// Some security providers (for example, Conscrypt) do not support
// SSLSession attributes, so perform a more expensive SNI retrieval.
Expand Down

0 comments on commit 4041e24

Please sign in to comment.