Merge pull request #342 from sv99/help-pos-required

Help for positional args without allcmd.ArgsRequired dependent from arg.Required
jessevdk · Jun 7, 2021 · 3927b71 · 3927b71
2 parents 4d0b7bb + 0259d21
commit 3927b71
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/help.go b/help.go
@@ -334,7 +334,11 @@ func (p *Parser) WriteHelp(writer io.Writer) {
 				}
 
 				if !allcmd.ArgsRequired {
-					fmt.Fprintf(wr, "[%s]", name)
+					if arg.Required > 0 {
+						fmt.Fprintf(wr, "%s", name)
+					} else {
+						fmt.Fprintf(wr, "[%s]", name)
+					}
 				} else {
 					fmt.Fprintf(wr, "%s", name)
 				}

diff --git a/help_test.go b/help_test.go
@@ -107,7 +107,7 @@ func TestHelp(t *testing.T) {
 
 		if runtime.GOOS == "windows" {
 			expected = `Usage:
-  TestHelp [OPTIONS] [filename] [num] [hidden-in-help] <bommand | command | parent>
+  TestHelp [OPTIONS] [filename] [num] hidden-in-help <bommand | command | parent>
 
 Application Options:
   /v, /verbose                              Show verbose debug information
@@ -156,7 +156,7 @@ Available commands:
 `
 		} else {
 			expected = `Usage:
-  TestHelp [OPTIONS] [filename] [num] [hidden-in-help] <bommand | command | parent>
+  TestHelp [OPTIONS] [filename] [num] hidden-in-help <bommand | command | parent>
 
 Application Options:
   -v, --verbose                             Show verbose debug information