Skip schema.rb when schema_format is set to :sql #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,8 @@ namespace :db do | |||
| namespace :schema do | |||
| desc "Create a db/schema.rb file that can be portably used against any DB supported by AR" | |||
| task :dump => :environment do | |||
| next unless ActiveRecord::Base.schema_format == :ruby | |||
There was a problem hiding this comment.
This seems to break db:migrate in recent versions of Rails:
NoMethodError: undefined method `schema_format' for ActiveRecord::Base:Class (NoMethodError)
It looks like ActiveRecord::Base.schema_format after Rails v3.2.13 was deprecated and removed. After that version it's just ActiveRecord.schema_format instead.
There was a problem hiding this comment.
good catch @jasonopslevel! fixed in #118 and released in v1.1.1 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #93.
Behavior stays the same as it was for Rails 5 and above.
As it's said in the issue, we don't need to generate a
schema.rbwhen we don't have the settingschema_format = :ruby.