Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74008] Remove SourceDetail/* #1884

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

yaroslavafenkin
Copy link
Contributor

https://issues.jenkins.io/browse/JENKINS-74008

I've searched for the class name in the jenkinsci org and the single reference that exists is in analysis-core-plugin, the distribution of which has been suspended.
My guess is that SourceDetail got replaced by SourceCodeViewModel from Prism API. SourceCodeViewModel/index.jelly had code that was very similar to what I'm removing here. Prism API got its fix in jenkinsci/prism-api-plugin#181.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (06e31fd) to head (b97fd7f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1884      +/-   ##
============================================
- Coverage     82.66%   82.56%   -0.10%     
+ Complexity     1366     1364       -2     
============================================
  Files           249      249              
  Lines          5243     5243              
  Branches        402      402              
============================================
- Hits           4334     4329       -5     
- Misses          799      803       +4     
- Partials        110      111       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner added the internal Internal changes without user or API impact label Nov 12, 2024
@uhafner
Copy link
Member

uhafner commented Nov 12, 2024

Yes you are right. I forgot to remove this code after the migration to the prism plugin!

@uhafner uhafner merged commit a3d584e into jenkinsci:main Nov 12, 2024
42 of 44 checks passed
@basil
Copy link
Member

basil commented Nov 19, 2024

Could this please be released? I don't think the removal will cause any problems, but in the (unlikely) chance that it does, it would be good to find out sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants