Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of values: delete metric subtypes #129

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Oct 23, 2024

To simplify generic metrics, it makes more sense to remove specific subtypes. Each subtype can be replaced by a concrete value instance. This makes handling of software metrics in post processing tools much simpler.

Example output of quality monitor:

Bildschirmfoto 2024-10-26 um 14 25 21

To simplify generic metrics, it makes more sense to remove specific
subtypes. Each subtype can be replaced by a concrete value instance.
@uhafner uhafner added the breaking Breaking Changes label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 94.30894% with 7 lines in your changes missing coverage. Please review.

Project coverage is 93.04%. Comparing base (fde5a84) to head (43de0f9).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/edu/hm/hafner/coverage/Metric.java 92.59% 2 Missing and 2 partials ⚠️
src/main/java/edu/hm/hafner/coverage/Value.java 90.90% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #129      +/-   ##
============================================
+ Coverage     92.98%   93.04%   +0.06%     
+ Complexity      903      840      -63     
============================================
  Files            33       28       -5     
  Lines          2380     2302      -78     
  Branches        355      340      -15     
============================================
- Hits           2213     2142      -71     
+ Misses           93       86       -7     
  Partials         74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 293 passed)
   〰️   Line Coverage: 96% (97 missed lines)
   ➰   Branch Coverage: 92% (81 missed branches)
   PIT   Mutation Coverage: 90% (115 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: No vulnerabilitys


Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result.

Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 293 passed)
   〰️   Line Coverage: 96% (88 missed lines)
   ➰   Branch Coverage: 92% (81 missed branches)
   PIT   Mutation Coverage: 90% (114 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: No vulnerabilitys


Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result.

Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 293 passed)
   〰️   Line Coverage: 96% (88 missed lines)
   ➰   Branch Coverage: 92% (81 missed branches)
   PIT   Mutation Coverage: 90% (114 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: 1 warning (normal: 1)
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: No vulnerabilitys


Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result.

Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 293 passed)
   〰️   Line Coverage: 96% (88 missed lines)
   ➰   Branch Coverage: 92% (81 missed branches)
   PIT   Mutation Coverage: 90% (114 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: No vulnerabilitys


Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result.

Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 293 passed)
   〰️   Line Coverage: 96% (86 missed lines)
   ➰   Branch Coverage: 92% (80 missed branches)
   PIT   Mutation Coverage: 90% (114 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: No vulnerabilitys


Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result.

@uhafner uhafner marked this pull request as ready for review October 27, 2024 09:27
@uhafner uhafner merged commit 0bcc7e9 into main Oct 27, 2024
33 checks passed
@uhafner uhafner deleted the generic-metrics branch October 27, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant