-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of values: delete metric subtypes #129
Conversation
To simplify generic metrics, it makes more sense to remove specific subtypes. Each subtype can be replaced by a concrete value instance.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
============================================
+ Coverage 92.98% 93.04% +0.06%
+ Complexity 903 840 -63
============================================
Files 33 28 -5
Lines 2380 2302 -78
Branches 355 340 -15
============================================
- Hits 2213 2142 -71
+ Misses 93 86 -7
Partials 74 74 ☔ View full report in Codecov by Sentry. |
☀️ Quality Monitor 🚦 Tests: 100 % successful (✔️ 293 passed) Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: 100 % successful (✔️ 293 passed) Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: 100 % successful (✔️ 293 passed) Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result. |
4a86b55
to
2a42add
Compare
☀️ Quality Monitor 🚦 Tests: 100 % successful (✔️ 293 passed) Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: 100 % successful (✔️ 293 passed) Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result. |
To simplify generic metrics, it makes more sense to remove specific subtypes. Each subtype can be replaced by a concrete value instance. This makes handling of software metrics in post processing tools much simpler.
Example output of quality monitor: