Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra.ci.jenkins.io) move end date for the Azure client password used by Azure VM agents plugin #759

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jun 27, 2024

Related to jenkins-infra/helpdesk#4154

This PR moves the end date definition to the YAML file used by updatecli to track dates.

  • Local tests shows there are no changes in Terraform plan: let's see what the CI checks tells us
  • Bumped the shared tools to ensure we have the latest version all the time
  • Naming: I used azurevms_agents_client_secret in the YAML file:
    • The prefix infraci_ does not make sense as this key is under the infra.ci.jenkins.io key
    • There are no corresponding environment variable that would fit the other keys naming convention: most probably because we started by this one, and then the resource sets grew over the initial naming.

…d used by Azure VM agents plugin

Signed-off-by: Damien Duportal <[email protected]>
@dduportal dduportal changed the title chore(infra.ci.jenkins.io) move end date for the Azure client passwor… chore(infra.ci.jenkins.io) move end date for the Azure client password used by Azure VM agents plugin Jun 27, 2024
@dduportal
Copy link
Contributor Author

Closing in favor of #760 as I was mistaken:

The data structure I changed in values.yaml is only used by the updatecli manifests used for the file shares SPs (as per the filenames). As such, the templates for PR body won't match at all.

@dduportal dduportal closed this Jun 27, 2024
@dduportal dduportal deleted the chore/infra.ci/factorize-azurevm-agent-enddate branch June 27, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant