-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lyrics styling #6385
Open
lxqueen
wants to merge
6
commits into
jellyfin:master
Choose a base branch
from
lxqueen:fix/lyrics-styling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix lyrics styling #6385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…witched to rem, shrunk slightly on non-large-desktop screens, horizontal padding for mobile)
Cloudflare Pages deployment
|
…w have a small forced height to separate said sections
lxqueen
force-pushed
the
fix/lyrics-styling
branch
from
December 15, 2024 15:33
4206945
to
002e423
Compare
Quality Gate passedIssues Measures |
(Force pushed to fix linting errors.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The styling for the lyrics page needed a tiny bit of TLC for a nicer cross-device experience.
Changes
rem
Comparison
* Don't worry about the serif font on TV, I was alternating by user agent rather than going into settings every time.