Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lyrics styling #6385

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

lxqueen
Copy link

@lxqueen lxqueen commented Dec 15, 2024

The styling for the lyrics page needed a tiny bit of TLC for a nicer cross-device experience.

Changes

  • Lyrics container now has extra top padding and max-width
  • Lyrics font size and bounding box now scales better on mobile & TV
    • Switched to rem
    • Shrunk slightly on non-large-desktop screens
    • Added horizontal padding for mobile
  • Added slight glow on dynamic lyric hover, with fast transition
  • Increased future lyric opacity slightly
  • Empty lyric lines (used as gap between sections in some LRC files) now have a small forced height to separate said sections

Comparison

Before After
Desktop desktop-before desktop-after-hovered
Mobile iphonese-before iphonese-after
TV* tv-before tv-after

* Don't worry about the serif font on TV, I was alternating by user agent rather than going into settings every time.

…witched to rem, shrunk slightly on non-large-desktop screens, horizontal padding for mobile)
@lxqueen lxqueen requested a review from a team as a code owner December 15, 2024 01:44
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Dec 15, 2024

Cloudflare Pages deployment

Latest commit 002e423
Status ✅ Deployed!
Preview URL https://6095ed08.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@lxqueen
Copy link
Author

lxqueen commented Dec 15, 2024

(Force pushed to fix linting errors.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants