Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add playlist access checks #5455

Merged
merged 3 commits into from
May 6, 2024
Merged

Add playlist access checks #5455

merged 3 commits into from
May 6, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Adds permission check for reordering playlist items
  • Adds permission check for removing playlist items
  • Make access public by default when creating a playlist
  • Updates icon for removing an item from a collection or playlist
  • Reduce log level for failed playlist permission api calls since they are expected to fail with invalid perms

Issues
Part of #4698

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label May 6, 2024
@thornbill thornbill added this to the v10.9.0 milestone May 6, 2024
@thornbill thornbill requested a review from a team as a code owner May 6, 2024 07:15
thornbill
thornbill commented May 6, 2024
View reviewed changes
src/scripts/playlistViewer.js
showIndex: false,
showRemoveFromPlaylist: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit bae48c4
Status ✅ Deployed!
Preview URL https://61589f3b.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

dmitrylyzo
dmitrylyzo approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

@joshuaboniface joshuaboniface merged commit 19c41cf into jellyfin:master May 6, 2024
10 checks passed
@thornbill thornbill deleted the playlist-access-checks-3 branch May 6, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

@MarkCiliaVincenti MarkCiliaVincenti MarkCiliaVincenti approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
No open projects
Release 10.9.z
Status: Done
Milestone
v10.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@thornbill @jellyfin-bot @MarkCiliaVincenti @dmitrylyzo @joshuaboniface