Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission check to playlist editor #5453

Merged
merged 3 commits into from
May 6, 2024
Merged

Add permission check to playlist editor #5453

merged 3 commits into from
May 6, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Adds permission check when listing playlists in the add to playlist dialog
  • Adds toast notifications when adding an item or creating a playlist fails

Issues
Part of #4698

@thornbill thornbill added the bug Something isn't working label May 5, 2024
@thornbill thornbill added this to the v10.9.0 milestone May 5, 2024
@thornbill thornbill requested a review from a team as a code owner May 5, 2024 18:38
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit df0af31
Status ✅ Deployed!
Preview URL https://16c2ce6e.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@joshuaboniface joshuaboniface merged commit 7700f15 into jellyfin:master May 6, 2024
12 checks passed
@thornbill thornbill deleted the playlist-access-checks branch May 6, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Release 10.9.z
Status: Done
Milestone
v10.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thornbill @jellyfin-bot @nielsvanvelzen @joshuaboniface