-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme correction #322
Readme correction #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Name the commit 1 as a6a72c8
Update Jellyfin Web branch
or
Update Jellyfin Web branch to 10.10.z
- Name the commit 2 as
Split build instructions for Jellyfin Web 10.8- and 10.9+
Simplified the process by splitting the instructions for easier copying.
Included steps for 10.8- for completeness, despite its likely lower usage.
Tbf, I'm not sure about the log message (long part) and whether this splitting is even necessary (because this also requires fixing the Windows wiki, which has Command line and PowerShell commands).
- Name the commit 3 as
Exclude gulpfile from packaging
gulpfile.js was renamed in 6a6a14cb9b3a6016db0a469aa3f14bdfc8a861d0
575ac0d
to
f9c5fa3
Compare
f9c5fa3
to
1d48ca2
Compare
Updating the wiki is necessary because of the gulpfile. |
Yes, but what I meant was, is the splitting 10.8/10.9 really worth? If we are going to continue splitting command sets, I think the remark blocks are a bit blended. mockup begin Build Jellyfin WebFor version 10.9+:cd jellyfin-web
npm ci --no-audit
USE_SYSTEM_FONTS=1 npm run build:production
For version 10.8-:cd jellyfin-web
SKIP_PREPARE=1 npm ci --no-audit
npm run build:production
If any changes are made to mockup end It is still not perfect, but 🤷 |
Than the easiest is to remove it. |
1d48ca2
to
c5c2275
Compare
gulpfile.js was renamed in 6a6a14c
c5c2275
to
ca20f6e
Compare
Fixes
Improvements
Added Latest Version: Updated the README to include the latest release version (release-10.10.z). (Improvement Commit)
Split Build Instructions: Separated build instructions for Jellyfin Web 10.8- and 10.9+ for clarity and ease of use. (Improvement Commit)