Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of Application Process for Samsung TV Seller Office #307

Draft
wants to merge 74 commits into
base: master
Choose a base branch
from

Conversation

UgaitzEtxebarria
Copy link

PR to visualize and organize the documentation of the process for Samsung TV Seller Office

@JasperJuergensen
Copy link

Got some time on my hands and was trying out the Tizen Studio Emulator. Created a Pull Request with some content for the language options section (felt like the easiest place to start): UgaitzEtxebarria#1

@UgaitzEtxebarria
Copy link
Author

Thank you very much, I don't have access to the app on tizen, just desktop or web, then every screenshot is welcome

@uxdesignerhector
Copy link

Official Jellifyn Icons and backgrounds for Tizen can be found on this repo https://github.com/jellyfin/jellyfin-ux under the next path https://github.com/jellyfin/jellyfin-ux/tree/master/branding/tizen. I have been looking to it and they are generating them with Inkscape and command line tools so we don't need to recreate them.

They seem to be following rules specified at Samsung's Guide for App icons the only thing we must take into account is that the naming should be logo_jellfyfin_fg.png and logo_jellyfin_bg.png as per official Samsung rules ( see here ), right now those images are named logo_fg.png and logo_bg.png

Here are the routes for foreground and background images:

@J-C-B
Copy link

J-C-B commented Nov 12, 2024

I have added about 30 flows and described screenshots that should be sufficient - happy to add more is needed

@dmitrylyzo
Copy link
Collaborator

dmitrylyzo commented Nov 26, 2024

  1. Are we going to store "Documentation" in this repo (we don't store it for webOS 🤷‍♂️ )?
    Currently we will have to exclude Documentation/* from the build. I was thinking of refactoring the build process to generate a separate dist folder from which the app will be packaged. So it won't be necessary in the future.

  2. Some screenshots are taken in the Desktop display mode. We should take them in the TV display mode. Documentation of Application Process for Samsung TV Seller Office #307 (comment)

  3. We need to clean up the git history of PR. Squash/rearrange commits.

@J-C-B
Copy link

J-C-B commented Nov 26, 2024

  1. Are we going to store "Documentation" in this repo (we don't store it for webOS 🤷‍♂️ )?
    Currently we will have to exclude Documentation/* from the build. I was thinking of refactoring the build process to generate a separate dist folder from which the app will be packaged. So it won't be necessary in the future.

    1. Some screenshots are taken in the Desktop display mode. We should take them in the TV display mode. Documentation of Application Process for Samsung TV Seller Office #307 (comment)

    2. We need to clean up the git history of PR. Squash/rearrange commits.

Sorry, not sure if you are asking me or Anthony, but here are my thoughts

1, It would be good to keep the documentation public and available should it need to be reused in the future - perhaps we could move it to the wiki? https://github.com/jellyfin/jellyfin-tizen/wiki
2, I Did setup the emulation as suggested about half way through - but found very little difference in the actual UI, personally I think they are a close enough likeness to the TV for the process. However if they are a must I can recapture them.
3, I am not sure how to do this, happy to take guidance on this process if I need to do something.

@UgaitzEtxebarria
Copy link
Author

UgaitzEtxebarria commented Nov 26, 2024

Alright, did a quick overview of the text. Seems to be all good, but I'll go through it further while comparing to the Samsung documentation just to make sure everything is landed correctly.

For the three Google Slides presentations I saw, I made copies to my own Google Drive account. We'll probably export them as .ODP files and keep them available for reference. Once I upload those, I'll remove the explicit links to Google in those readme files, and point to the uploaded version instead.

I'll take care of updating the logos to use the new font.

Once I've updated the images and uploaded the slides/ODP, then I'll push to this branch, convert it to "ready" status, and merge.

I agree with @dmitrylyzo, this MR was created to store the documentation, not to been merged and add unnecessary info for who need just compile the code. I specified some options here #222 (comment), and was selected store it on a branch. We can change if its a better way to manage the documentation.

Apart from that, I am creating new issues with the problems that people says, if you look any issue that needs to be add, just add it.

Thanks for all contribution

@J-C-B
Copy link

J-C-B commented Dec 5, 2024

@dmitrylyzo and @anthonylavado - I have created the new screenshots in the TV ui - I am just unclear how to provide them based on the discssion above and dont want to keep re-creating documentation.

I looked at the main jellyfin project and they have docs in a docs folder - https://github.com/jellyfin/jellyfin.org/tree/master/docs - as does the roku app - https://github.com/jellyfin/jellyfin-roku/tree/master/docs - why could we not do the same? it would be consistant with the main project then. There are also github pages that could be used that reference the docs folder to show a tidy static site

If we use the wiki feature of github we will still need an images directory hosted somewhere to be able to show the screenshots in the wiki via url in any case.

I am happy to help and contribute in the way you would like me to, but would like a solid direction to go in before I spend the time to do it.

@J-C-B
Copy link

J-C-B commented Dec 19, 2024

Hi @anthonylavado - i have made updates a couple of weeks ago - are you able to review? is the application submitted? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants