Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily add a better suited Jellyfin launcher icon #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dqbd
Copy link

@dqbd dqbd commented Feb 4, 2023

This only fixes the issue for development builds, but it is a fix nonetheless.

Fixes #171

@dmitrylyzo dmitrylyzo added the enhancement New feature or request label Feb 4, 2023
@dmitrylyzo
Copy link
Collaborator

The background should be #000b25 (https://github.com/jellyfin/jellyfin-ux/blob/b33401d1d08e13ca3f189ecb8ec60158cfd60d9a/branding/SVG/icon-solid-black.svg)

I believe Samsung just crops the "Icon" (512x423) to square (423x423): jellyfin/jellyfin-ux#46
Since I added that one as an "Icon", we can crop it. Tbh, I don't like 423px.
icon3

@mjeshurun
Copy link

Hi Friends,
Tizen TV apps icons are usually not square in shape, but have an oblong shape.
Would it be possible to update the jellyfin-tizen app icon to this one?
It has better dimensions to fit better next to the other Tizen TV apps.

icon

@Aasikki
Copy link

Aasikki commented Apr 21, 2023

Hi Friends, Tizen TV apps icons are usually not square in shape, but have an oblong shape. Would it be possible to update the jellyfin-tizen app icon to this one? It has better dimensions to fit better next to the other Tizen TV apps.

icon

They are definitely square on my 2020 tv, maybe both formats are needed?

@mjeshurun
Copy link

Here is a photo of my tv’s home shortcuts.
as you can see, the icon for the Jellyfin app is the only one with a perfect square dimension. All the other icons are longer in length.
hope this helps explain what I meant.

IMG_3622

@Aasikki
Copy link

Aasikki commented Apr 24, 2023

Yes but on some tv's they are perfectly square, like here on mine.
IMG_20230424_194936

@mjeshurun
Copy link

Ohhhh Samsung... Can't even keep the same UI on it's own TV's 🤦🏻

@FancyNerd92
Copy link

Ohhhh Samsung... Can't even keep the same UI on it's own TV's 🤦🏻

It's not wrong just you have and older tv with an older version of Tizen. On Tizen 6+ is change the style.

@inluxc
Copy link

inluxc commented Oct 26, 2023

Why not have both for different versions 😆

@santiagodevelop
Copy link

Hello, I have the same problem and I don't really know how to change the size of the icon. Is there a manual on how to do it?

@morpheus133
Copy link
Contributor

This will solve it:
jeppevinkel/jellyfin-tizen-builds#53
And there will be images build with "oblong" icon

@morpheus133
Copy link
Contributor

Is this PR still needed?
For temporary workaround there is an build with oblong icon at:
https://github.com/jeppevinkel/jellyfin-tizen-builds/releases

And when Samsung accept the app, we hope that it will solve by them.

@santiagodevelop
Copy link

Is this PR still needed? For temporary workaround there is an build with oblong icon at: https://github.com/jeppevinkel/jellyfin-tizen-builds/releases

And when Samsung accept the app, we hope that it will solve by them.

Hello, I'm not sure if there's a solution for this. In my case, I need the icon to be rectangular. I see that in the repository there's a file called "Jellyfin-10.10.z-OblongIcon.wgt", but I'm not sure if this is the version that fixes it. If so, how can I update the app on my TV? Would it be possible to publish a manual with the basic guidelines?

@morpheus133
Copy link
Contributor

Sorry, I thought that the PR is related to this icon:

icon

Because this is done with the mentioned release.

Install guide is here:
https://github.com/Georift/install-jellyfin-tizen use Jellyfin-OblongIcon as parameter

@santiagodevelop
Copy link

Sorry, I thought that the PR is related to this icon:

icon

Because this is done with the mentioned release.

Install guide is here: https://github.com/Georift/install-jellyfin-tizen use Jellyfin-OblongIcon as parameter

OK, I think I got it. In this process, it would not be necessary to use Tizen Studio, it would be done through Docker. It would be to use this instance if I want to install the latest version: docker run --rm ghcr.io/georift/install-jellyfin-tizen 192.168.0.10 Jellyfin-OblongIcon "https://github.com/jeppevinkel/jellyfin-tizen-builds/releases/tag/2024-11-24-0431"

Can you confirm if I'm right? I don't have much knowledge about Tizen. Thanks for your help.

@santiagodevelop
Copy link

Perfect, updated the application from Docker without problems with the correct icon for my TV model. Thank you very much.
20241219_130708

@mjeshurun
Copy link

Sorry for the question, but is there a Jellyfin-Tizen app version that is both Jellyfin 10.10 with support for the intro skipper plugin and has an oblong icon?

I don’t see that as an option for download.

@morpheus133
Copy link
Contributor

Sorry for the question, but is there a Jellyfin-Tizen app version that is both Jellyfin 10.10 with support for the intro skipper plugin and has an oblong icon?

I don’t see that as an option for download.

You need to clink on show all xx assests:
image

This is the direct link to it.
https://github.com/jeppevinkel/jellyfin-tizen-builds/releases/download/2024-11-24-0431/Jellyfin-intros-OblongIcon.wgt

But I dont know it is still working or not.
In the newer version of Jellyfin there is some native support for intro skipping but I think it is not working on Tizen.

@mjeshurun
Copy link

This is the direct link to it. https://github.com/jeppevinkel/jellyfin-tizen-builds/releases/download/2024-11-24-0431/Jellyfin-intros-OblongIcon.wgt

But I dont know it is still working or not. In the newer version of Jellyfin there is some native support for intro skipping but I think it is not working on Tizen.

Thank you for the suggestion, @morpheus133 🙏
Like you said, last time I tried to install the Jellyfin-intros-OblongIcon.wgt version on my Tizen TV, the Intro Skipper's on-screen buttons didn't show up on the screen, so I needed to switch back to the Jellyfin-10.10.z-intros.wgt version.

@morpheus133
Copy link
Contributor

morpheus133 commented Dec 19, 2024

Thank you for the suggestion, @morpheus133 🙏 Like you said, last time I tried to install the Jellyfin-intros-OblongIcon.wgt version on my Tizen TV, the Intro Skipper's on-screen buttons didn't show up on the screen, so I needed to switch back to the Jellyfin-10.10.z-intros.wgt version.

Did that work?
Because in Jellyfin-intros-OblongIcon.wgt and Jellyfin-intros.wgt the only diff must be that the icon is changed.

I think at the moment there is no working intro skipping for tizen.
(old method is break because of Jellyfin-web update)

Maybe Jellyfin-10.9.z-intros.wgt can work, but for that older version of intro-skipper plugin and most probably older server version is needed.

@mjeshurun
Copy link

The latest versions of Jellyfin-10.10.z-intros.wgt are working properly on Tizen, and intro skipper is working as it should with them.

I tested Jellyfin-intros-OblongIcon.wgt on Tizen when Jellyfin 10.10 came out, but intro skipper didn’t work with that version.
I didn’t test that file version again since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix icon in TV launcher
8 participants