Support anidb id in Season rather than Series #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anidb ids map to a specific season of a show rather than an entire series
nalsai
reviewed
Jul 12, 2022
| @@ -9,7 +9,7 @@ namespace Jellyfin.Plugin.AniDB.Providers.AniDB | |||
| public class AniDbExternalId : IExternalId | |||
| { | |||
| public bool Supports(IHasProviderIds item) | |||
| => item is Series || item is Movie; | |||
| => item is Series || item is Season || item is Movie; | |||
There was a problem hiding this comment.
This only adds the ability to add the providerid to seasons.
You also need to add something in AniDbSeasonProvider.cs to actually add the providerid.
I can do it when I have time, if you want me to.
There was a problem hiding this comment.
I am not entirely sure what needs to be done, so if you could do it I would appreciate it :D.
h1dden-da3m0n
added
the
feature
|
is there any plan to implement this? |
|
Converted to draft, as it sounds like more code is needed for this to be useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anidb ids map to a specific season of a show rather than an entire series