[feat] Create "Add current track" button in playlist view #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix dependency list Add success toast
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This adds a feature similar to what is mentioned in #556 |
kgarner7
reviewed
Apr 3, 2024
| title: t('error.genericError', { postProcess: 'sentenceCase' }), | ||
| }); | ||
| }, | ||
| }, |
There was a problem hiding this comment.
You should move the toast.success to onSuccess here
kgarner7
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Thanks for the commit! A few other thoughts:
- This doesn't consider duplicates (e.g. adding the same song multiple times)
- The new icon isn't quite intuitive, maybe it'd be worthwhile to remove the delay for tooltip (or another icon)
I'm also not sure if this is necessarily appropriate period, but I'll defer to @jeffvli for that.
| const base = { defaultFullPlaylist, handlePlay: handlePlayPlaylist }; | ||
| const base = { | ||
| defaultFullPlaylist, | ||
| handleAdd: handleAddCurrent, |
There was a problem hiding this comment.
This should not be enabled for Navidrome shared playlists (only the owner can change them)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm enjoying using Feishin as my music player for my library. I thought it would be nice to add a "Add current track" button to the playlist sidebar. That way, when a song is playing, I can quickly add it to as many playlists as I feel like it belongs in.
Currently, I have it hiding the button if the playlist has rules (ie, a smart playlist). You can add a song to a shared playlist, but if you don't have (admin) permission, it throws an error toast.
This also allows adding duplicates of a song to a playlist, so a toggle somewhere to disable duplicates could be a nice feature.
I'm not a React dev and haven't really contributed to open source, so if there's any issues please let me know! I think I did a decent job, but I'm always looking for ways to make my code better.