Changes to comply with PEP8 #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to make script cleaner and comply with PEP8.
prjemian
reviewed
Oct 23, 2022
| @@ -42,8 +43,15 @@ def _request(self, url, method='GET', params={}, headers={}, stream=False, raw=F | |||
| req_log.propagate = True | |||
| """ | |||
|
|
|||
| if params in None: | |||
|
This PR would be easier to review if the code refactoring was separate from the changes for PEP8 compliance. Python black could be used to make code style more consistent. |
| @@ -20,11 +20,14 @@ | |||
| import sys | |||
|
|
|||
| if sys.version[0] == '2': | |||
There was a problem hiding this comment.
If we're not going to support python 2, I'd prefer all the related code just be removed rather than commented out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to make code cleaner and to comply with PEP8. #30