Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMS_VERSION variable added #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

GMS_VERSION variable added #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fe4481
Add GMS_VERSION variable
nurfgun Aug 28, 2019
2bdcde2
Update README.md
nurfgun Aug 28, 2019
e2986b4
Update plugin.xml
nurfgun Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,13 @@ INCOMING_CALL_APP_NAME | PhoneApp | Users will get a notification that they have
ENABLE_CALL_KIT | true | This plugin has optional CallKit support for iOS 10 and above. ENABLE_CALL_KIT should be "true" or "false"
MASK_INCOMING_PHONE_NUMBER | false | This plugin has optional ability to mask the incoming phone number. MASK_INCOMING_PHONE_NUMBER should be "true" or "false"
DEBUG_TWILIO | false | Optionally enable twilio library debugging. DEBUG_TWILIO should be "true" or "false"
GMS_VERSION | 10.2.1 | Optionally choose `play-services` library version


# Configuring `play-services` Version

Many other plugins require Google Play Services and/or Firebase libraries. This is a common source of Android build-failures, since the `play-services` library version must be aligned to the same version for **all** plugins. For example, when one plugin imports version `11.0.1` and another one imports `11.2.0`, a gradle build failure will occur. Use the `GMS_VERSION` to align the required play-services version with other plugins.

```
cordova plugin add cordova-plugin-google-analytics --variable GMS_VERSION=11.0.1
```
3 changes: 2 additions & 1 deletion plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@
</config-file>

<framework src="com.google.gms:google-services:3.0.0" />
<framework src="com.google.firebase:firebase-messaging:10.2.1" />
<framework src="com.google.firebase:firebase-messaging:$GMS_VERSION" />
<preference name="GMS_VERSION" default="10.2.1"/>
<framework src="com.twilio:voice-android:2.0.7"/>

<source-file src="src/android/com/phonegap/plugins/twiliovoice/TwilioVoicePlugin.java"
Expand Down