-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add media failed animation #89
base: master
Are you sure you want to change the base?
Conversation
ace55c3
to
32663db
Compare
6eeac02
to
de78f3c
Compare
I'm not very keen on animations, they tend to use a suprisingly large amount of CPU time when they're many of them. But I'm quite open to such a change if we verify that the CPU time is not too large. |
4f84b48
to
0d2ca28
Compare
@erdnaxe, just to let you know that I am interested in this patch, and I'm keenly waiting for you to find the right approach. |
I am not convinced by the solution I proposed here. Maybe we could avoid showing something on the whole video and rather use What do you think of displaying an element in Proposition of layout, both media are failing, but on the left I am hovering with my mouse: (I made this screenshot using the Web inspector and adding a SVG element in the top controls, I can patch the JS if it turns out to be what we want.) |
I fear it's not visible enough. Think about the usage scenario: you are giving a lecture, and suddenly your connection has an issue. You want to notice it straight away. |
65fa0be
to
03038ea
Compare
b7172df
to
8de77fe
Compare
Proposal for #87.
Some notes:
<video>
does not seem to support::before
CSS modifier.Is it problematic if we add an element next to
<video>
to place this animation?