Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggable stack trace formatting #447

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Nov 16, 2023

This is a potential approach to allow a pluggable stack trace formatter.

Note a couple of important points:

  • Service loader cannot be used at this early stage of bootstrap. It doesn't overtly fail with an exception, but certain things fail to initialize in the right order randomly resulting in sporadic and hard-to debug unit test failures. Idea: introduce a private logmanager-safe service loader, if we want more things to be pluggable?
  • There is only one global stack trace formatter. It might be possible to allow different stack trace formatters per each PatternFormatter, but this would require extra logic and configuration which would need to be thought out somehow.
  • This kind of functionality would be necessary to support something like provide source file context for exception message quarkusio/quarkus#37002

@dmlloyd
Copy link
Member Author

dmlloyd commented Nov 19, 2024

I want to see how this could interplay with a general formatting API. I'll keep it here for reference for now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant