This repository has been archived by the owner on May 4, 2018. It is now read-only.
Created plugin for getting artifacts from local dir #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable plugin with --artifact-local-enable Set the director with --artifact-local-dir (default is artifacts) Fixes: 114
rwngwn
reviewed
Jun 26, 2017
dogen/plugins/artifact.py
Outdated
|
|
||
| for f in sorted(self.artifact_files): | ||
| self.log.debug("Copying local artifact %s" % os.path.basename(f)) | ||
| shutil.copy2(f, self.output) |
There was a problem hiding this comment.
how this handle target?
https://github.com/jboss-dockerfiles/dogen/blob/develop/dogen/generator.py#L289
artifacts in dogen can be copied anywhere into the subtree of output directory - this functionality is crucial to CCT plugin. This probably needs to be updated. @goldmann opinion?
There was a problem hiding this comment.
The target name could be used in the artifacts directory. The sources would then find it and pick it up.
I'll need to update to handle subdirectories. If the artifacts directory contains the subdirectories and target names, they can be copied over.
rwngwn
reviewed
Jun 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable plugin with --artifact-local-enable
Set the director with --artifact-local-dir (default is artifacts)
Fixes: 114