Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ods: add style to datetime, date and time values #594

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

pascalfree
Copy link
Contributor

This solves #210 but for the ods format.

Let me know if you agree with this approach in general. I will then apply the same for datetime and time types.

Code is inspired by https://stackoverflow.com/a/28577394
I tested it with LibreOffice 7.3 so far.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (9c82f70) to head (8189db6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
+ Coverage   92.66%   92.68%   +0.01%     
==========================================
  Files          28       28              
  Lines        2958     2966       +8     
==========================================
+ Hits         2741     2749       +8     
  Misses        217      217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claudep
Copy link
Contributor

claudep commented Jul 9, 2024

Would you be able to add some test for that change?

I find the commit message a bit misleading, as this is fixing ods export functionality, not ods reading.

@pascalfree pascalfree changed the title feat: display date as date when opening ods feat: ods: add style to datetime, date and time values Jul 10, 2024
@pascalfree
Copy link
Contributor Author

I changed the title and added tests.

The tests currently fail, because the datetime export has a bug that was previously covered by the import: #595

@claudep
Copy link
Contributor

claudep commented Jul 13, 2024

Please rebase after merge of #595

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@claudep claudep merged commit be9cd93 into jazzband:master Jul 16, 2024
22 checks passed
@pascalfree pascalfree deleted the ods_date branch December 1, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants