Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ods): None values are not displayed as string #566

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

hoccau
Copy link

@hoccau hoccau commented Oct 26, 2023

Actually, None values are converted in string in an ODS sheet (so 'None' string is displayed in cells). This fill a cell empty value in case of None.
Sorry for not providing test : I see that ODS is tested only globally. It could be improved later :)
Thanks!

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #566 (aec46cb) into master (8e2004c) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   92.40%   92.41%           
=======================================
  Files          28       28           
  Lines        2938     2941    +3     
=======================================
+ Hits         2715     2718    +3     
  Misses        223      223           
Files Coverage Δ
src/tablib/_vendor/dbfpy/dbf.py 68.75% <ø> (ø)
src/tablib/_vendor/dbfpy/dbfnew.py 97.67% <ø> (ø)
src/tablib/_vendor/dbfpy/fields.py 71.27% <ø> (ø)
src/tablib/_vendor/dbfpy/header.py 83.16% <ø> (ø)
src/tablib/_vendor/dbfpy/record.py 76.38% <ø> (ø)
src/tablib/_vendor/dbfpy/utils.py 90.32% <ø> (ø)
src/tablib/formats/_dbf.py 100.00% <100.00%> (ø)
src/tablib/formats/_ods.py 99.24% <100.00%> (+0.01%) ⬆️
tests/test_tablib.py 98.84% <100.00%> (+<0.01%) ⬆️
tests/test_tablib_dbfpy_packages_fields.py 100.00% <100.00%> (ø)
... and 1 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@claudep
Copy link
Contributor

claudep commented Oct 27, 2023

I would suggest waiting for PR #568 to be merged, then you can rebase and take advantage of the new import functionality to complement the tests.

@hoccau
Copy link
Author

hoccau commented Oct 27, 2023

I would suggest waiting for PR #568 to be merged, then you can rebase and take advantage of the new import functionality to complement the tests.

ok, fine.

@hoccau hoccau force-pushed the fix/ods-none-value branch from 91e8234 to aec46cb Compare November 8, 2023 09:37
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That looks good.

@claudep claudep merged commit 26ded27 into jazzband:master Nov 8, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants