Internal: use a single registry for abstractify APIs #25651
+48
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2810
approved these changes
Dec 20, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
jakevdp
force-pushed
the
combine-abstractify
branch
2 times, most recently
from
e635995 to
80048ff
Compare
jakevdp
force-pushed
the
combine-abstractify
branch
from
80048ff to
0fda407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #25616.
We still need the three APIs for now, because their behavior is slightly different (differences that were unclear to me until I embarked on this refactoring!).
Once this cleanup is in, we can begin looking at the uses of each to see how important these differences are in practice.