add error checks for refs, behind a flag #25449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some error checks for incorrect ustage of mutable array references. The checks are behind a flag, default off, because there are probably some downstream users that need to be updated, and we want to defer doing that until all the checks land.
This PR only adds checks for
jit
, namely:We need to do the same for all higher-order primitives (HOPs): scan, cond, while_loop, and custom_jvp/vjp. I'm going to leave those as follow-ups so we can iterate on getting the jit errors right, since those will largely follow the same pattern.
Here are some example error messages: