Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewed articles in 1-js/01-getting started #21

Merged
merged 4 commits into from
Apr 19, 2022

Conversation

minna-xD
Copy link
Contributor

@minna-xD minna-xD commented Oct 4, 2021

I reviewed "An Introduction to JavaScript" and the index.md found in the 1-js/01-getting-started folder.
I've made one "harmonization" edit: "JavaScipt" can be inflected with A or Ä endings (-issa/-issä, -a/ä). I personally prefer the A inflection but I believe Ä is very commonly used because it follows the pronunciation, so I've used that one.

relates to #7

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Oct 4, 2021
@javascript-translate-bot javascript-translate-bot requested a review from a team October 4, 2021 17:36
@CLAassistant
Copy link

CLAassistant commented Oct 4, 2021

CLA assistant check
All committers have signed the CLA.

@minna-xD
Copy link
Contributor Author

minna-xD commented Oct 4, 2021

Finished reviewing the rest of the articles in 01-getting-started 😊

@minna-xD minna-xD changed the title Reviewed 1-01 index and article Reviewed articles in 1-js/01-getting started Oct 4, 2021
@niemenjoki
Copy link
Contributor

@minna-xD Thanks for your review. I apologize for taking so long to notice this PR.

@niemenjoki niemenjoki merged commit e189f19 into javascript-tutorial:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review needed Review needed, please approve or request changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants