Skip to content

Commit

Permalink
Forced dependency version
Browse files Browse the repository at this point in the history
Forcing bevy_ecs_tilemap to 0.11.1 fixes the bug!
  • Loading branch information
janos-r committed Nov 26, 2023
1 parent 58eb950 commit 3a37ab9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,7 @@ bevy_rapier2d = "0.22"
# bevy_ecs_ldtk is using bevy_ecs_tilemap
# bevy_ecs_tilemap has to be run with a feature flag when building to wasm, as they explain here <https://github.com/StarArawn/bevy_ecs_tilemap#running-examples-on-web>
# As expained in the cargo book <https://doc.rust-lang.org/cargo/reference/features.html#feature-unification>, when you define here THE SAME VERSION of the dependency with the required feature, it is automatically accessible also to your other dependencies and solves the issue that bevy_ecs_ldtk doesn't provide a way to activate this through their features.
[target.'cfg(target_arch = "wasm32")'.dependencies]
bevy_ecs_tilemap = { version = "0.11", features = ["atlas"] }

# [target.'cfg(target_arch = "wasm32")'.dependencies]
# specific 0.11.1 to fix a bug in 0.11.0 (and for some reason it didn't update automatically with a 0.11)
bevy_ecs_tilemap = { version = "0.11.1", features = ["atlas"] }
7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,3 @@ code.
- bevy_ecs_ldtk issue
- workaround: some ground objects had to be remade as entities
- <https://github.com/Trouv/bevy_ecs_ldtk/issues/152>

## Ongoing bug after upgrade to 0.11

- After loading a level (entering the hous or going back), the tiles are not
rendered anymore. Entities are.
- bevy_ecs_ldtk issue, possibly bevy_ecs_tilemap issue
https://github.com/StarArawn/bevy_ecs_tilemap/pull/451

0 comments on commit 3a37ab9

Please sign in to comment.