Replace home page banner image #989
Conversation
|
Could you also post both landscape and portrait mobile browser screenshots, please? |
|
@jamulussoftware/designers @jamulussoftware/translators @jamulussoftware/maindevelopers |
assets/css/home.css
Outdated
| @@ -81,3 +81,21 @@ body.is-os-other #quick_dl_container a.os-other { | |||
| transition: 0.4s; | |||
| opacity: 0.9; | |||
| } | |||
|
|
|||
| figure { | |||
There was a problem hiding this comment.
I'd prefer a separate class for this image instead of styling the whole figure.
There was a problem hiding this comment.
Note sure I know how to do that properly. Can you give an example?
There was a problem hiding this comment.
For the figure in question add a class attribute: class="sth" then use the sth class in css
There was a problem hiding this comment.
To have the style for the figure part of the class, you mean? Would we not do that for all figures though? I didn't want to change too much with this PR (there is also #673 BTW which may be related)
There was a problem hiding this comment.
I mean if you think that it's for all figures put it into fw.css not home.css.
I'd just assume that you may not want the exact same styling for each figure?
Maybe the center alignment is different? If you're sure that you want to apply this for each figure element, then go for it. But not in home.css
There was a problem hiding this comment.
I didn't intend this to be a global figure style change, but I'm also not sure why the figure isn't styled the same as the others unless I duplicate the the figure in home.css. Anyway, I'll change that so it just has a class to center the text.
There was a problem hiding this comment.
Probably this has to do with the order in which the css files get loaded. home.css is strictly only for what happens on the home page while fw.css is integrated everywhere.
| </a> | ||
| <figure> | ||
| <a href="wiki/Getting-Started" rel="canonical"> | ||
| <img src="{% include img/en-screenshots/main-screen-medium.inc %}" style="border: 5px solid grey;" id="jamulusbanner" loading="lazy" alt="A screenshot of the main mixer window showing five people from different countries connected."> |
There was a problem hiding this comment.
Also add the solid gray border thing either in a separate class or add figure>img rule in the css
Co-authored-by: ann0see <[email protected]>
Co-authored-by: ann0see <[email protected]>
This was briefly suggested with mild agreement a while ago: to show a screenshot of Jamulus on the home page so as to give people a better idea of what to expect.
Does this need translation?
YES
(since the screenshot could be in other languages)
iPhone 12 Pro:
Checklist