Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Sort by Server Channel" to mixer view #1060

Merged

Conversation

pljones
Copy link
Contributor

@pljones pljones commented Oct 30, 2024

Short description of changes

Updates Software Manual to explain the View > Sort... options more fully. (Also fixed trailing white space issues.)

Updates Tips and Tricks to correct a couple of problems and mention Sort by Server Channel.

Context: Fixes an issue? Related issues
Fixes #1059

Status of this Pull Request
I've checked it locally. I'll grab the built site and put it on my preview hosting once it's there.

What is missing until this pull request can be merged?
Review.

Does this need translation?
Yes, normal Weblate translations. No new screenshots.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

@pljones pljones added this to the Release 3.12.0 milestone Oct 30, 2024
@pljones pljones self-assigned this Oct 30, 2024
@pljones pljones linked an issue Oct 30, 2024 that may be closed by this pull request
@pljones pljones requested review from ann0see and gilgongo October 30, 2024 10:50
wiki/en/Software-Manual.md Show resolved Hide resolved
wiki/en/Software-Manual.md Show resolved Hide resolved
wiki/en/Tips-Tricks-More.md Outdated Show resolved Hide resolved
@pljones pljones force-pushed the sort-faders-by-channel branch from 392bb78 to fd3eb56 Compare October 31, 2024 18:04
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise from a quick glance looks ok

wiki/en/Software-Manual.md Outdated Show resolved Hide resolved
@pljones pljones force-pushed the sort-faders-by-channel branch from fd3eb56 to 25c8e91 Compare November 21, 2024 16:53
wiki/en/Software-Manual.md Outdated Show resolved Hide resolved
wiki/en/Software-Manual.md Outdated Show resolved Hide resolved
wiki/en/Software-Manual.md Outdated Show resolved Hide resolved
wiki/en/Software-Manual.md Outdated Show resolved Hide resolved
wiki/en/Software-Manual.md Outdated Show resolved Hide resolved
wiki/en/Software-Manual.md Outdated Show resolved Hide resolved
wiki/en/Software-Manual.md Outdated Show resolved Hide resolved
@pljones pljones marked this pull request as draft November 24, 2024 14:47
@pljones
Copy link
Contributor Author

pljones commented Nov 24, 2024

Set to draft as this will get reworked / dropped after jamulussoftware/jamulus#3426 merges.

@pljones
Copy link
Contributor Author

pljones commented Dec 4, 2024

@softins do you want to pick this up for your version of the change?

@softins softins marked this pull request as ready for review December 6, 2024 14:48
@softins softins requested a review from ann0see December 6, 2024 14:48
@softins
Copy link
Member

softins commented Dec 6, 2024

@pljones would you like to review my changes? I can't request review from you as it's your PR.

I'll do #1053 after this is merged, as they overlap slightly.

wiki/en/Software-Manual.md Outdated Show resolved Hide resolved
wiki/en/Tips-Tricks-More.md Outdated Show resolved Hide resolved
@pljones
Copy link
Contributor Author

pljones commented Dec 6, 2024

Nothing major.

@softins softins merged commit c97be00 into jamulussoftware:next-release Dec 6, 2024
1 check passed
@pljones
Copy link
Contributor Author

pljones commented Dec 6, 2024

@softins I've posted the build here: http://jamuluswebsite.drealm.info/

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. (Post merge review)

@pljones pljones deleted the sort-faders-by-channel branch December 7, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Docs: Add "Sort by Server Channel" to mixer view
4 participants