Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RSpec/DescribedClass cop to explicit #180

Merged

Conversation

tagliala
Copy link
Contributor

Additionally:

  • Autofix offenses
  • Update RuboCop dependencies and set require to false
  • Regenerate rubocop_todo.yml

Ref: #177 (comment)

Additionally:
- Autofix offenses
- Update RuboCop dependencies and set require to false
- Regenerate rubocop_todo.yml

Ref: jamesmartin#177 (comment)
@tagliala tagliala mentioned this pull request Dec 15, 2024
2 tasks

# https://github.com/jamesmartin/inline_svg/pull/177#issuecomment-2530239552
RSpec/DescribedClass:
EnforcedStyle: explicit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesmartin I've configured the cop as you requested and also fixed existing described_class offenses

Copy link
Owner

@jamesmartin jamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tagliala. Much appreciated! ✨

@jamesmartin jamesmartin merged commit 087d347 into jamesmartin:master Dec 15, 2024
7 checks passed
@tagliala tagliala deleted the chore/configure-described-class-cop branch December 15, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants