Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use File::NULL instead of hardcoded /dev/null #174

Merged

Conversation

tagliala
Copy link
Contributor

Allow to run specs in file systems where /dev/null is not supported, like Windows.

Tested on GitHub Actions, with runs-on: windows-latest


Before

https://github.com/tagliala/inline_svg/actions/runs/11981009383

After

https://github.com/tagliala/inline_svg/actions/runs/11981044155

Allow to run specs in file systems where `/dev/null` is not
supported, like Windows.

Tested on GitHub Actions, with `runs-on: windows-latest`
Copy link
Owner

@jamesmartin jamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks! ✨

@jamesmartin jamesmartin merged commit 8c74576 into jamesmartin:master Nov 29, 2024
7 checks passed
@tagliala tagliala deleted the chore/allow-tests-on-windows branch December 2, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants