-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript rewrite, new options, improved workflows & whatnot #30
Open
EndBug
wants to merge
32
commits into
jamesgeorge007:typescript-rewrite
Choose a base branch
from
EndBug:rewrite
base: typescript-rewrite
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
f947e7d
feat: add NO_DEPENDABOT option
EndBug aedc573
build: update dist
EndBug 0dd6db5
chore: npm audit fix
EndBug db3369b
chore: run prettier
EndBug 6625b8a
fix: fix initialization error
EndBug 5f7a63a
Upload new action code
EndBug f61d037
ci: fix typo
EndBug b59ba64
ci: don't run tests on macOS
EndBug c740c63
ci: install dependecies
EndBug 74eca0f
chore: lint source code
EndBug a73e419
build: update dist
EndBug cc8ea04
fix: minor fix
EndBug 983567e
build: update dist
EndBug 65fe788
fix: fix commit behaviour
EndBug f5a1b73
build: update dist
EndBug 35baa4e
fix: try to filter out duplicates
EndBug ad6b90e
chore: lint source code
EndBug 2f8b17a
build: update dist
EndBug b8af06f
ci: remove test workflow
EndBug 86ea2e5
build: update dist
EndBug 4ee59a6
chore: use git hooks instead of GH actions
EndBug 72abe63
Merge branch 'master' of git://github.com/jamesgeorge007/github-activ…
EndBug 9c6632d
Merge branch 'jamesgeorge007-master' into rewrite
EndBug b2ed64b
ci: add test workflow
EndBug 3eec2c7
fix: change param to MAX_LINE (instead of LINE)
EndBug cc4a7e9
chore: rename workflow
EndBug f387559
fix: update email address
EndBug 2ad1698
chore: fix conflicts
EndBug 89301e2
chore: fix conflicts
EndBug fd9cb99
chore: fix conflicts
EndBug 21796ff
chore: fix merge conflicts?
EndBug 3052d7d
Merge branch 'rewrite' of https://github.com/EndBug/github-activity-r…
EndBug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
semi: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the motivation behind introducing this input param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one?
NO_COMMIT
orLINES
?NO_COMMIT
: if someone wants to do some other edit to the README they can do it and then push all the changes in a single commit.LINES
: they can select the number of lines from the workflowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're checking to see if there is any difference between the content enclosed within the respective comments and the latest data being pulled. Any change made to other sections of the
README
doesn't affect this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesgeorge007 That's not the issue: I may want to do some other changes to the README and then commit everything together, instead of having multiple commits.