Skip to content

Commit

Permalink
Update eslint
Browse files Browse the repository at this point in the history
  • Loading branch information
@jakebailey
jakebailey committed Dec 9, 2024
1 parent 7b510bb commit 5454345
Show file tree
Hide file tree
Showing 6 changed files with 727 additions and 810 deletions.
127 changes: 0 additions & 127 deletions .eslintrc.json
View file

This file was deleted.

9 changes: 4 additions & 5 deletions .ncurc.cjs
View file
Original file line number Diff line number Diff line change
@@ -1,22 +1,21 @@
module.exports = {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
target: (dependencyName, [{ semver, version, operator, major, minor, patch, release, build }]) => {
if (dependencyName === "ava") return "patch"; // Trying to support Node 12.
if (dependencyName === "@ava/typescript") return "minor"; // Trying to support Node 12.
if (dependencyName === "execa") return "patch"; // Trying to support Node 12.
if (dependencyName === "command-line-usage") return "minor"; // Package got big.
if (dependencyName === "pretty-ms") return "minor"; // For old versions of node.
if (dependencyName === "eslint") return "minor";
if (dependencyName === "eslint-plugin-ava") return "minor";
if (dependencyName === "rimraf") return "minor";
if (dependencyName === "tinybench") return "patch";
if (dependencyName === "npm") return "minor";
if (major === "0") return "minor";
return "latest";
},
// eslint-disable-next-line @typescript-eslint/no-unused-vars
reject: (name, semver) => {
if (name === "tmp") {
return true;
}
if (name === "tmp") return true;
if (name === "picocolors") return true;
return false;
},
};
152 changes: 152 additions & 0 deletions eslint.config.mjs
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@
// @ts-check
import eslint from "@eslint/js";
import eslintPluginAva from "eslint-plugin-ava";
import eslintPluginSimpleImportSort from "eslint-plugin-simple-import-sort";
import eslintPluginUnicorn from "eslint-plugin-unicorn";
import globals from "globals";
import tseslint from "typescript-eslint";

export default tseslint.config(
{
files: ["**/*.{ts,tsx,cts,mts,js,cjs,mjs}"],
},
{
ignores: [
"**/dist/**",
"**/node_modules/**",
"bin/**",
"coverage/**",
"Herebyfile.mjs",
],
},
eslint.configs.recommended,
...tseslint.configs.strictTypeChecked,
...tseslint.configs.stylisticTypeChecked,
eslintPluginUnicorn.configs["flat/recommended"],
eslintPluginAva.configs["flat/recommended"],
{
languageOptions: {
parserOptions: {
warnOnUnsupportedTypeScriptVersion: false,
ecmaVersion: "latest",
sourceType: "module",
project: true,
},
globals: globals.node,
},
plugins: {
"simple-import-sort": eslintPluginSimpleImportSort,
},
},
{
"rules": {
"eqeqeq": "error",
"no-constant-condition": "off",
"no-inner-declarations": "off",
"no-undef": "off",
"no-unused-vars": "off",
"no-restricted-globals": ["error", "console", "process", "Date"],
"simple-import-sort/imports": "error",
"simple-import-sort/exports": "error",
"@typescript-eslint/no-import-type-side-effects": "error",
// In theory good, but less good when declaring a new interface and
// stopping to think about its contents.
"@typescript-eslint/no-empty-interface": "off",
"@typescript-eslint/no-namespace": "off",
"@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }],
"@typescript-eslint/no-use-before-define": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-unsafe-argument": "off",
"@typescript-eslint/no-unsafe-assignment": "off",
"@typescript-eslint/no-unsafe-call": "off",
"@typescript-eslint/no-unsafe-member-access": "off",
"@typescript-eslint/no-unsafe-return": "off",
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/no-empty-object-type": "off",
"@typescript-eslint/require-await": "off",
"@typescript-eslint/restrict-template-expressions": "off",
"@typescript-eslint/naming-convention": [
"error",
{
"selector": [
"classProperty",
"typeProperty",
"parameterProperty",
"classMethod",
"typeMethod",
"accessor",
],
"modifiers": ["private"],
"leadingUnderscore": "require",
"format": ["camelCase"],
"filter": {
"regex": "^(test_| )",
"match": false,
},
},
{
"selector": [
"classProperty",
"typeProperty",
"parameterProperty",
"classMethod",
"typeMethod",
"accessor",
],
"modifiers": ["protected"],
"leadingUnderscore": "allow",
"format": ["camelCase"],
"filter": {
"regex": "^(test_| )",
"match": false,
},
},
{
"selector": [
"classProperty",
"typeProperty",
"parameterProperty",
"classMethod",
"typeMethod",
"accessor",
],
"modifiers": ["public"],
"leadingUnderscore": "forbid",
"format": ["camelCase"],
"filter": {
"regex": "^(test_| )",
"match": false,
},
},
],
"@typescript-eslint/no-unnecessary-condition": ["error", {
"allowConstantLoopConditions": true,
}],
"unicorn/catch-error-name": "off",
"unicorn/filename-case": "off",
"unicorn/no-array-callback-reference": "off",
"unicorn/no-await-expression-member": "off",
"unicorn/no-useless-undefined": "off",
"unicorn/prefer-top-level-await": "off", // Reenable once Node 12 is dropped.
"unicorn/prevent-abbreviations": "off",
"unicorn/switch-case-braces": "off",
"unicorn/prefer-string-replace-all": "off", // Bad suggestion for old targets
},
},
{ "files": ["Herebyfile.*", "**/__fixtures__/**"], "rules": { "no-restricted-globals": "off" } },
{
"files": ["**/__tests__/**"],
"rules": {
"@typescript-eslint/no-empty-function": "off",
"no-restricted-globals": "off",
"ava/no-import-test-files": "off",
},
},
{
files: [
".ncurc.cjs",
"eslint.config.mjs",
],
extends: [tseslint.configs.disableTypeChecked],
},
);
Loading

0 comments on commit 5454345

Please sign in to comment.