Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2][adjuster] Implement model to otlp translator with post processing #6397

Merged
merged 8 commits into from
Dec 24, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • Implemented a translator in jptrace with a function ProtoToTraces that is a wrapper of the upstream ProtoToTraces in opentelemetry-collector-contrib jaeger translator. This function appends the warnings in model.Span to the jaeger.internal.warnings attribute in the corresponding span in ptrace.Traces.

How was this change tested?

  • Added unit tests

Checklist

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (5b1c76b) to head (e81f991).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6397      +/-   ##
==========================================
+ Coverage   96.24%   96.28%   +0.04%     
==========================================
  Files         366      366              
  Lines       20918    20946      +28     
==========================================
+ Hits        20132    20168      +36     
+ Misses        601      595       -6     
+ Partials      185      183       -2     
Flag Coverage Δ
badger_v1 8.97% <0.00%> (-0.03%) ⬇️
badger_v2 1.84% <51.16%> (+0.20%) ⬆️
cassandra-4.x-v1-manual 14.92% <0.00%> (-0.05%) ⬇️
cassandra-4.x-v2-auto 1.78% <51.16%> (+0.20%) ⬆️
cassandra-4.x-v2-manual 1.78% <51.16%> (+0.20%) ⬆️
cassandra-5.x-v1-manual 14.92% <0.00%> (-0.05%) ⬇️
cassandra-5.x-v2-auto 1.78% <51.16%> (+0.20%) ⬆️
cassandra-5.x-v2-manual 1.78% <51.16%> (+0.20%) ⬆️
elasticsearch-6.x-v1 18.60% <0.00%> (-0.06%) ⬇️
elasticsearch-7.x-v1 18.68% <0.00%> (-0.07%) ⬇️
elasticsearch-8.x-v1 18.85% <0.00%> (-0.05%) ⬇️
elasticsearch-8.x-v2 1.84% <51.16%> (+0.21%) ⬆️
grpc_v1 10.64% <0.00%> (-0.02%) ⬇️
grpc_v2 8.12% <51.16%> (+0.18%) ⬆️
kafka-v1 9.33% <0.00%> (-0.03%) ⬇️
kafka-v2 1.84% <51.16%> (+0.20%) ⬆️
memory_v2 1.83% <51.16%> (+0.19%) ⬆️
opensearch-1.x-v1 18.73% <0.00%> (-0.07%) ⬇️
opensearch-2.x-v1 18.73% <0.00%> (-0.07%) ⬇️
opensearch-2.x-v2 1.84% <51.16%> (+0.21%) ⬆️
tailsampling-processor 0.47% <0.00%> (-0.01%) ⬇️
unittests 95.14% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/jptrace/translator.go Outdated Show resolved Hide resolved
internal/jptrace/translator.go Outdated Show resolved Hide resolved
internal/jptrace/translator.go Outdated Show resolved Hide resolved
Signed-off-by: Mahad Zaryab <[email protected]>
internal/jptrace/warning.go Outdated Show resolved Hide resolved
internal/jptrace/translator.go Outdated Show resolved Hide resolved
internal/jptrace/translator.go Outdated Show resolved Hide resolved
Signed-off-by: Mahad Zaryab <[email protected]>
@yurishkuro yurishkuro merged commit 53468aa into jaegertracing:main Dec 24, 2024
54 checks passed
@mahadzaryab1 mahadzaryab1 deleted the translation-2 branch December 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants