Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade storage integration tests to Storage v2 API #6369

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Ayush-Vish
Copy link

Which problem is this PR solving?

Fixes #6366

Description of the changes

  • Added test for the TraceReader

How was this change tested?

  • make test

Checklist

Signed-off-by: Ayush Vishwakarma <[email protected]>
@Ayush-Vish Ayush-Vish requested a review from a team as a code owner December 16, 2024 15:49
@Ayush-Vish
Copy link
Author

Ayush-Vish commented Dec 16, 2024

@yurishkuro I have Added a test for the TraceReader
Could you let me know if I am in the right direction?
Thanks.

@yurishkuro
Copy link
Member

I don't think you understood the objective of the issue. This PR doesn't address it in any way. I never said we need "a test for v2 reader".

@yurishkuro
Copy link
Member

There is an extensive README about integration tests in cmd/jaeger/internal/integration. We're missing another one in the base module plugin/storage/integration, I will see if I can add one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade storage integration tests to Storage v2 API
2 participants