Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve telemetry.Settings #6275

Merged
merged 19 commits into from
Nov 29, 2024
+382 −241

code review

5bc515e
Select commit
Loading
Failed to load commit list.
Merged

Improve telemetry.Settings #6275

code review
5bc515e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 29, 2024 in 0s

89.65% of diff hit (target 95.00%)

View this Pull Request on Codecov

89.65% of diff hit (target 95.00%)

Annotations

Check warning on line 61 in cmd/jaeger/internal/extension/jaegerquery/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/jaeger/internal/extension/jaegerquery/server.go#L60-L61 

Added lines #L60 - L61 were not covered by tests

Check warning on line 324 in cmd/query/app/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/query/app/server.go#L323-L324 

Added lines #L323 - L324 were not covered by tests

Check warning on line 339 in cmd/query/app/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/query/app/server.go#L338-L339 

Added lines #L338 - L339 were not covered by tests

Check warning on line 356 in cmd/query/app/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cmd/query/app/server.go#L355-L356 

Added lines #L355 - L356 were not covered by tests
View more details on Codecov