Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus] Use OTEL helper instead of tlscfg package #6266

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

chahatsagarmain
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

@chahatsagarmain chahatsagarmain requested a review from a team as a code owner November 28, 2024 11:06
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (58e08c5) to head (33129e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6266      +/-   ##
==========================================
- Coverage   96.41%   96.41%   -0.01%     
==========================================
  Files         355      355              
  Lines       20158    20154       -4     
==========================================
- Hits        19436    19432       -4     
  Misses        532      532              
  Partials      190      190              
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <0.00%> (+<0.01%) ⬆️
elasticsearch-6.x-v1 18.60% <ø> (ø)
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.85% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.66% <0.00%> (-0.01%) ⬇️
grpc_v1 9.44% <ø> (ø)
grpc_v2 6.98% <0.00%> (+<0.01%) ⬆️
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <0.00%> (+<0.01%) ⬆️
memory_v2 1.67% <0.00%> (+0.01%) ⬆️
opensearch-1.x-v1 18.72% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.67% <0.00%> (+<0.01%) ⬆️
tailsampling-processor 0.46% <0.00%> (+<0.01%) ⬆️
unittests 95.33% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chahatsagarmain and others added 2 commits November 28, 2024 21:36
Signed-off-by: chahatsagarmain <[email protected]>
@yurishkuro yurishkuro enabled auto-merge (squash) November 28, 2024 16:18
@yurishkuro yurishkuro merged commit 4a14e87 into jaegertracing:main Nov 28, 2024
52 checks passed
@chahatsagarmain chahatsagarmain deleted the prometheus-tlscfg branch November 28, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants