Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][storage_v2] move factoryadapter to storage_v2 #6216

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Nov 16, 2024

Which problem is this PR solving?

Description of the changes

  • While working on [v2][storage] Implement read path for v2 storage interface #6170, I hit a roadblock where I was unable to use the factoryadapter from the query_service because the factoryadapter was defined in cmd/jaeger/internal/extension/jaegerstorage which made it unaccessible from query/app/querysvc. This PR proposes to move this adapter to the storage_v2 package so that it can be accessed from the query service.

How was this change tested?

  • CI

Checklist

@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review November 16, 2024 16:04
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner November 16, 2024 16:04
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (2b7cf3a) to head (f57e63b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6216      +/-   ##
==========================================
- Coverage   96.50%   96.49%   -0.02%     
==========================================
  Files         354      354              
  Lines       20127    20127              
==========================================
- Hits        19424    19421       -3     
- Misses        520      522       +2     
- Partials      183      184       +1     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.68% <ø> (ø)
elasticsearch-8.x-v1 18.85% <ø> (ø)
elasticsearch-8.x-v2 1.66% <ø> (-0.02%) ⬇️
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.00% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 18.73% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahadzaryab1 mahadzaryab1 changed the title [WIP][chore][storage_v2] move factoryadapter to storage_v2 [chore][storage_v2] move factoryadapter to storage_v2 Nov 16, 2024
@yurishkuro yurishkuro merged commit eb6c5c9 into jaegertracing:main Nov 16, 2024
50 of 54 checks passed
@mahadzaryab1 mahadzaryab1 deleted the move-adapter branch November 16, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants